Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGL: Avoid HDR mode. Uses unknownbrackets' changes from #11839. #11845

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

hrydgard
Copy link
Owner

Fixes #11839 .

@hrydgard hrydgard added this to the v1.8.0 milestone Feb 26, 2019
@hrydgard hrydgard deleted the egl-avoid-hdr branch February 26, 2019 08:02
@hrydgard hrydgard merged commit 2e70fe1 into master Feb 26, 2019
@@ -120,6 +125,11 @@ EGLConfig EGL_FindConfig(int *contextVersion) {
EGLint caveat = readConfig(EGL_CONFIG_CAVEAT);
int caveatScore = caveat == EGL_NONE ? 100 : (caveat == EGL_NON_CONFORMANT_CONFIG ? 50 : 0);

#ifndef USING_FBDEV
EGLint surfaceType = readConfig(EGL_SURFACE_TYPE);
int surfaceScore = (surfaceType & EGL_WINDOW_BIT) ? 100 : (caveat == EGL_NON_CONFORMANT_CONFIG ? 50 : 0);
Copy link
Collaborator

@unknownbrackets unknownbrackets Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, wait, this might accidentally boost non-conformant configs? Copy/paste mistake (possibly mine)?

-[Unknown]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I just took it verbatim from your post :) You're right that this might not be great..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants