softgpu: Use threads on self-render if safe #16387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some games, such as Prince of Persia, self-render 1:1 to colorize, rather than to scale or blur. We can still use threads in these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games, such as Prince of Persia, self-render 1:1 to colorize, rather than to scale or blur. We can still use threads in these cases.
This improves Prince of Persia - Rival Swords performance by almost 10% (63% -> 69% speed.) It'd be safe to avoid flushing here too, but that's harder since we have to recalculate on each if it's safe.
This might not help games that use tiny tiles as well unless we recognize and combine them, which we might already be doing.
-[Unknown]