Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Don't use multithreaded rendering if buffer commands (frames in flight) is set to 1 #17831

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Aug 1, 2023

Let's turn it off in this particular case, as it then has no benefit (no overlapping processing), and loses by a few percent in simple benchmarking.

We'll still keep the dev option to turn off multithreading for other cases if desired, but there's not much point in exposing it more, I think - this is the one case where it's a positive.

A little bit hard to centralize the logic since it's kinda spread out between the context and render manager.

Will make it cleaner at a later point, there's some refactoring I want to do in this area.

…to 1

It has no benefit, and loses by a few percent in simple benchmarking.
@hrydgard hrydgard added the Vulkan label Aug 1, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Aug 1, 2023
@hrydgard hrydgard merged commit 7538807 into master Aug 1, 2023
19 checks passed
@hrydgard hrydgard deleted the no-inflight-no-multithreading branch August 1, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant