Make GetIndexBounds friendlier to autovectorization. Works on x86 at least. #18219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it MSVC? Concerning either way. |
|
Ok, I can reproduce MSVC getting |
unknownbrackets
approved these changes
Sep 24, 2023
|
Oh, I didn't read the disassembly very carefully (I just breakpointed and "show disassembly" in MSVC itself, which produces rather hard-to-read output). If it's runtime detected it's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all games use indexed draws at all, but should be a small boost for those that do and draw a lot of geometry.
Although I noticed I was getting pmaxuw instructions on my machine, which are SSE4.1. Should the compiler really generate those? Weird! (MSVC)