Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEMSIZE flag not respected in homebrew(?) #9719

Closed
LunaMoo opened this issue May 24, 2017 · 2 comments
Closed

MEMSIZE flag not respected in homebrew(?) #9719

LunaMoo opened this issue May 24, 2017 · 2 comments

Comments

@LunaMoo
Copy link
Collaborator

LunaMoo commented May 24, 2017

Tried to check that Quake II port homebrew for other issues, and it's currently crashing due to lack of memory despite having MEMSIZE flag set to 1, as can be seen:
quake 2 memsize
In case the location matters, it's PARAM.SFO is packed inside memstick\PSP\GAME\QuakeII\EBOOT.PBP.
Extracted PARAM.SFO looks ok I guess -
quake param

When it comes to MEMSIZE, it certainly does work fine with commercial games, that is while using ISO, not sure why it fails with homebrew.:]

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented May 24, 2017

Is it not reaching here?

UseLargeMem(paramSFO.GetValueInt("MEMSIZE"));

Maybe it has to do with the PSP_PBP_DIRECTORY stuff.

-[Unknown]

@LunaMoo
Copy link
Collaborator Author

LunaMoo commented May 24, 2017

It wasn't reaching to neither of the two MEMSIZE checks there, and yeah it goes through PSP_PBP_DIRECTORY then to Load_PSP_ELF_PBP which doesn't have MEMSIZE check.

Adding InitMemoryForGamePBP(loadedFile); to case IdentifiedFileType::PSP_PBP_DIRECTORY: fixes it, so I guess I'll open PR with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants