From 33e9e43ff50da9dc976e99f95a641844083879e2 Mon Sep 17 00:00:00 2001
From: Danika MacDonell <43050968+danikam@users.noreply.github.com>
Date: Fri, 19 Mar 2021 16:11:53 -0700
Subject: [PATCH] Move `--docker-login` from end of `singularity shell` command
 to before image name

It was found by Yury Smirnov that if the environment variables `SINGULARITY_DOCKER_USERNAME`, `SINGULARITY_DOCKER_PASSWORD` aren't pre-set, the `--docker-login` only works in the `singularity shell` command if put in front of the image name, not after.
---
 _episodes/10-singularity.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/_episodes/10-singularity.md b/_episodes/10-singularity.md
index 4ca345d..05012bd 100644
--- a/_episodes/10-singularity.md
+++ b/_episodes/10-singularity.md
@@ -99,7 +99,7 @@ export SINGULARITY_DOCKER_PASSWORD='mysecretpass'
 > > ## Solution
 > > ~~~bash
 > > export SINGULARITY_CACHEDIR="/tmp/$(whoami)/singularity"
-> > singularity shell -B /afs -B /eos -B /cvmfs docker://gitlab-registry.cern.ch/[repo owner's username]/[skimming repo name]:[branch name]-[shortened commit SHA] --docker-login
+> > singularity shell -B /afs -B /eos -B /cvmfs --docker-login docker://gitlab-registry.cern.ch/[repo owner's username]/[skimming repo name]:[branch name]-[shortened commit SHA]
 > > ~~~
 > > {: .source}
 > {: .solution}