Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal tests to vx-gradient components #114

Merged
merged 5 commits into from
Aug 17, 2017
Merged

Add minimal tests to vx-gradient components #114

merged 5 commits into from
Aug 17, 2017

Conversation

Ffloriel
Copy link
Contributor

@Ffloriel Ffloriel commented Aug 8, 2017

No description provided.

- add standard 'render without crashing' tests
@hshoff
Copy link
Member

hshoff commented Aug 16, 2017

Hi @Ffloriel thanks for checking out vx and adding more coverage!

A couple things for this to land:

Once those are done, I'd be happy to merge.

- keep consistent with other vx packages by using test function
@Ffloriel
Copy link
Contributor Author

Hi @hshoff
I was actually trying to be consistent when I changed to it (2 files were using it) but I didn't look at the other packages. It makes more sense to use test in that situation. I will make the requested changes

@hshoff
Copy link
Member

hshoff commented Aug 17, 2017

@Ffloriel ah that was my fault. thanks for the updates! looks good to me.

@hshoff hshoff merged commit d774661 into airbnb:master Aug 17, 2017
@hshoff hshoff added this to the v0.0.136 milestone Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants