Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readme for vx/hierarchy #136

Merged
merged 1 commit into from
Sep 3, 2017

Conversation

trainorpj
Copy link
Contributor

I have a few notes/questions:

  1. It appears that className is passed as a prop to both components, but is never actually called, so I didn't include it in the props table. Am I missing something here?
  2. The props size, nodeSize, and separation are all passed to the respective d3 layouts, and that's where the defaults are being set (not in the vx components). Should we mention this, or is it not a big deal?
  3. Should this readme include more details on nodeComponent and linkComponent? Is there a plan to have defaults for these, like in vx/network?

Link to components for convenience.

Let me know if anything needs clarification!

@hshoff
Copy link
Member

hshoff commented Sep 3, 2017

Awesome thank you @trainorpj!

  1. This is a bug. Will fix.
  2. Also a bug. Will fix.
  3. Good catch, should probably default them like @vx/network

@hshoff hshoff added this to the v0.0.0138 milestone Sep 3, 2017
@hshoff hshoff merged commit 81642a1 into airbnb:master Sep 3, 2017
@trainorpj trainorpj deleted the write-hierarchy-readme branch September 4, 2017 12:46
@trainorpj trainorpj mentioned this pull request Sep 4, 2017
@hshoff hshoff modified the milestones: v0.0.138, v0.0.0138 Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants