Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a few notes/questions:
className
is passed as a prop to both components, but is never actually called, so I didn't include it in the props table. Am I missing something here?size
,nodeSize
, andseparation
are all passed to the respective d3 layouts, and that's where the defaults are being set (not in the vx components). Should we mention this, or is it not a big deal?nodeComponent
andlinkComponent
? Is there a plan to have defaults for these, like in vx/network?Link to components for convenience.
Let me know if anything needs clarification!