Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vx axis tests #161

Merged
merged 4 commits into from
Oct 26, 2017
Merged

Vx axis tests #161

merged 4 commits into from
Oct 26, 2017

Conversation

Ffloriel
Copy link
Contributor

@Ffloriel Ffloriel commented Oct 1, 2017

  • add unit test with scaleBand instead of scaleLinear
  • tickStroke has a default value, making stroke unreachable (line 135)?

@Ffloriel
Add test with scaleBand
ceb597d 
- add unit test with scaleBand instead of scaleLinear
@Ffloriel
remove unreachable value
97e19d4 
- tickStroke has a default value, making stroke unreachable
@hshoff
Copy link
Member

hshoff commented Oct 2, 2017

Thanks for this @Ffloriel! I need to take a look at why an unrelated test is broken. Will get this merged soon.

@hshoff hshoff added this to the v0.0.141 milestone Oct 2, 2017
@hshoff hshoff modified the milestones: v0.0.141, v0.0.143 Oct 13, 2017
@hshoff hshoff modified the milestones: v0.0.143, v0.0.145 Oct 26, 2017
@hshoff hshoff merged commit b3659c7 into airbnb:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.145
Development

Successfully merging this pull request may close these issues.
2 participants
@Ffloriel @hshoff