Fix center and add pointRadius, innerRef #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM thank you! |
kachkaev
reviewed
Nov 9, 2023
| if (rotate) currProjection.rotate(rotate); | ||
| if (precision) currProjection.rotate(precision); | ||
| if (fitExtent) currProjection.fitExtent(...fitExtent); | ||
| if (fitSize) currProjection.fitSize(...fitSize); | ||
|
|
||
| const path = geoPath().projection(currProjection); | ||
|
|
||
| if (pointRadius) path.pointRadius(pointRadius); |
There was a problem hiding this comment.
Suggested change
| if (pointRadius) path.pointRadius(pointRadius); | |
| if (pointRadius !== undefined) path.pointRadius(pointRadius); |
👋 folks! Do you if pointRaidus can be 0? Would it be a valid input? I can change this in #1767 if it makes sense.
There was a problem hiding this comment.
hey @kachkaev according to the d3-geo docs this should be a 2-element numerical array https://d3js.org/d3-geo/projection#projection_center
that's consistent with our @visx/geo types / docs https://airbnb.io/visx/docs/geo#Projection_center
so I don't think 0 is valid.
There was a problem hiding this comment.
I think it’s related to https://d3js.org/d3-geo/path#path_pointRadius (one number)
There was a problem hiding this comment.
🤦 🤦 🤦 sorry no idea how I misread that one. 100% agree with you/thanks for adding in your new PR 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 Breaking Changes
None.
🚀 Enhancements
Added pointRadius and fixed center.
📝 Documentation
🐛 Bug Fix
Fixed center typo.
🏠 Internal