Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Prettier for consistent code formatting #275

Merged
merged 2 commits into from
Apr 28, 2018
Merged

Conversation

sto3psl
Copy link
Contributor

@sto3psl sto3psl commented Apr 21, 2018

This PR adds code formatting on commits with Prettier and lint-staged. This should make the dev experience a little better since no one should think about formatting code and instead just get going and develop awesome stuff.

I used lint-staged in favour of pretty-quick or precise-commits with the thought of adding an eslint config later to the pre-commit. Neither pretty-quick nor precise-commits offer this.

🏠 Internal

  • adds configuration for Prettier and formats the existing codebase
  • set up pre-commit hook to format changed files before commits

New dev dependencies:

@hshoff
Copy link
Member

hshoff commented Apr 28, 2018

Yesssssssss, love this! Thank you @sto3psl 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants