Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Custom Rendering For Pie Charts #311

Merged
merged 2 commits into from
Jun 20, 2018
Merged

Conversation

paul-sachs
Copy link
Contributor

I'd like to be able to animate a pie chart but for most animation frameworks, we need access to the children groups in order to modify the path parameters. By adding an optional render function, we can add animation to the pie chart while allowing users to choose their own animation framework.

💥 Breaking Changes

None

🚀 Enhancements

  • Add optional render function as child of Pie to allow more fine grained control of rendering.

Paul Sachs and others added 2 commits June 15, 2018 11:29
I'd like to be able to animate a pie chart but for most animation frameworks, we need access to the children groups in order to modify the path parameters. By adding an optional render function, we can add animation to the pie chart while allowing users to choose their own animation framework.
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@hshoff hshoff added this to the v0.0.168 milestone Jun 20, 2018
@hshoff hshoff merged commit 3ecb926 into airbnb:master Jun 20, 2018
@hshoff
Copy link
Member

hshoff commented Jun 22, 2018

published in v0.0.168 https://github.com/hshoff/vx/releases/tag/v0.0.168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants