Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[development] add linting #346

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Conversation

geekplux
Copy link
Contributor

@geekplux geekplux commented Sep 5, 2018

✨ Development

If you run npm run lint, you would discover there are:

✖ 10557 problems (10488 errors, 69 warnings)
  6731 errors and 0 warnings potentially fixable with the `--fix` option.

lol 😂

Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I guess I haven't been that consistent over the past year and a half. I suppose the sooner we add this the better.

LGTM other than adding dist to .eslintignore.

Thanks for the contribution!

.eslintignore Show resolved Hide resolved
@hshoff hshoff added this to the v0.0.175 milestone Sep 6, 2018
@hshoff hshoff merged commit 09d89cb into airbnb:master Sep 7, 2018
@geekplux geekplux deleted the development/add_linting branch September 7, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add linting
2 participants