Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Equal Earth projection to @vx/geo #407

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Add Equal Earth projection to @vx/geo #407

merged 3 commits into from
Jan 8, 2019

Conversation

lorenries
Copy link
Contributor

🚀 Enhancements

  • Adds the Equal Earth projection to @vx/geo. Equal Earth is pretty new (was added to d3-geo a couple months ago), but is becoming increasingly popular because it doesn't really distort land masses and their areas. See this for more info.

hshoff
hshoff reviewed Jan 8, 2019
View reviewed changes
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! this is a great addition. Would you mind updating the comment and then running npm run docs from the root of the vx repo and pushing the changes?

I still need to figure out how to run the doc update script from CI

packages/vx-geo/src/projections/EqualEarth.js Outdated Show resolved Hide resolved
@hshoff hshoff added this to the v0.0.184 milestone Jan 8, 2019
@lorenries
Copy link
Contributor Author

Updated with docs. Thanks @hshoff!

hshoff
hshoff approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@hshoff hshoff merged commit 635749c into airbnb:master Jan 8, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

Assignees
No one assigned
Labels
🚀enhancement
Projects
None yet
Milestone
v0.0.184
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenries @hshoff