fix(vx-responsive): fix enhancer parent/screen size checks #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Feb 4, 2020
| > | ||
| {parentWidth !== null && parentHeight !== null && ( | ||
| <div style={CONTAINER_STYLES} ref={this.setRef}> | ||
| {parentWidth != null && parentHeight != null && ( |
There was a problem hiding this comment.
Do we want to check for 0 as well?
| @@ -54,7 +54,7 @@ export default function withScreenSize<BaseComponentProps extends WithScreenSize | |||
|
|
|||
| render() { | |||
| const { screenWidth, screenHeight } = this.state; | |||
| if (!screenWidth && !screenHeight) return null; | |||
| if (screenWidth == null || screenHeight == null) return null; | |||
There was a problem hiding this comment.
Do we want to check for 0 as well?
|
hmm 🤔 if it is I think it's okay for us to pass |
|
Also noting that rendering with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Fixes #619 where the TS re-write introduced a regression wherein the state is initialized with
undefined, while the render method checks fornulls@hshoff @kristw
cc @dson