Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pattern] Add tests for pattern circles #63

Merged
merged 1 commit into from
Jun 11, 2017
Merged

[pattern] Add tests for pattern circles #63

merged 1 commit into from
Jun 11, 2017

Conversation

Flaque
Copy link
Contributor

@Flaque Flaque commented Jun 11, 2017

Changes

  • Moves the embedded anonymous function that created circles into it's own separate function so that it can be easily tested.
  • Added tests for createCircles

Testing done

  • Ran tests.
  • Ran Demo to prove that everything still looks fine visually:

What Demo Looks Like
(Still looks normal)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 27.127% when pulling ec6e3f2 on Flaque:evan--circle-tests into 080274c on hshoff:master.

@hshoff
Copy link
Member

hshoff commented Jun 11, 2017

👍

@hshoff hshoff added this to the v0.0.120 milestone Jun 11, 2017
@hshoff hshoff merged commit d734229 into airbnb:master Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.120
Development

Successfully merging this pull request may close these issues.
3 participants
@Flaque @coveralls @hshoff