-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tooltip default styles #666
Conversation
@dennisja thanks for the PR including tests! 🙌 It differs slightly from the solution @hshoff discussed/proposed in #650, instead of adding this would support the current behavior + |
6b2d90d
to
657a902
Compare
74c6196
to
f270170
Compare
I have changed it to behave like how @hshoff suggested but there is an issue with the implementation. If a user accidentally uses the tooltip like <Tooltip unstyled style={{...someStylesAUserWantsToApply}} /> The styles will not be applied |
@dennisja thanks for this contribution! I think that the case you call out is okay, will try and get this out in the |
out in |
Just a note that this is a breaking change for anyone who was passing in a style prop to Tooltip. Might be worth updating the CHANGELOG to reflect that. |
We’ll update the changelog. For now, work around is to import defaultStyles and extend it through style prop. <Tooltip style={{ ...defaultStyle, style }} /> |
Updated the changelog and included a before/after 👍 |
💥 Breaking Changes
🚀 Enhancements
📝 Documentation
🐛 Bug Fix
🏠 Internal
Fixes #650