Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vx-gradient): update to docgen #706

Merged
merged 1 commit into from
May 22, 2020

Conversation

williaster
Copy link
Collaborator

📝 Documentation

Part of #680, updates @vx/gradient docs to the new non-static docgen.

After
image
image

Before
image

@hshoff @kristw

@williaster williaster added this to the v1 milestone May 14, 2020
@williaster williaster mentioned this pull request May 14, 2020
@@ -4,7 +4,7 @@ import LinearGradient, { LinearGradientProps } from './LinearGradient';
/**
* All props pass through to `<LinearGradient {...props} />`
*/
export default function GradientDarkGreen({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docgen barfs (not really, it just doesn't parse props correctly) if the component name + file name don't match 😅

@williaster williaster merged commit 1a4cb41 into chris--fix-docgen May 22, 2020
@williaster williaster deleted the chris--docgen-gradient branch May 22, 2020 21:53
@hshoff hshoff modified the milestones: v1, v0.0.197 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants