-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(vx-demo): link all docs <> examples #731
Merged
williaster
merged 10 commits into
chris--link-docs-to-examples
from
chris--link-docs-to-examples-part-ii
May 28, 2020
Merged
new(vx-demo): link all docs <> examples #731
williaster
merged 10 commits into
chris--link-docs-to-examples
from
chris--link-docs-to-examples-part-ii
May 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
approved these changes
May 28, 2020
packages/vx-demo/src/pages/Text.tsx
Outdated
/> | ||
); | ||
}; | ||
const packageJson = { dependencies: { '@vx/text': 'lateset' } }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Documentation
🏠 Internal
This PR builds on #729 which added the hooks to link doc pages to examples, and examples to docs, and links the remaining docs + examples:
vx
doc links to all demo pagesGalleryTile
thumbnails to mostpages/doc/*
pagesSome examples
@hshoff @kristw