-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add diagonal right to left pattern #744
Conversation
thanks for the addition @dennisja! could you add a screenshot of it working (maybe a comparison to the other diagonal to see feature parity)? |
WDYT of adding a select in the boxplot example where one can choose the pattern to show? |
@dennisja that sounds good, or alternatively could add to the |
@williaster Adding it to the Pattern example sounds and looks better. It is what I have gone with |
7dae369
to
f835222
Compare
@williaster I noticed that the build is failing because of some types that are not related to the pull request. I don't know whether it will be a good idea fixing them in this PR for the build to pass. Is can we add an issue to fix them or should I go ahead and fix them in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the build, thanks again for this addition @dennisja!
f835222
to
bd3ab7b
Compare
🚀 Enhancements
Fixes #723
Screenshots