Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add diagonal right to left pattern #744

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

dennisja
Copy link
Contributor

@dennisja dennisja commented Jun 11, 2020

🚀 Enhancements

  • Add diagobalRightToLeft orientation

Fixes #723

Screenshots

Screenshot 2020-06-17 at 08 49 50
Screenshot 2020-06-17 at 08 49 57

@williaster
Copy link
Collaborator

thanks for the addition @dennisja! could you add a screenshot of it working (maybe a comparison to the other diagonal to see feature parity)?

@dennisja
Copy link
Contributor Author

thanks for the addition @dennisja! could you add a screenshot of it working (maybe a comparison to the other diagonal to see feature parity)?

WDYT of adding a select in the boxplot example where one can choose the pattern to show?

@williaster
Copy link
Collaborator

@dennisja that sounds good, or alternatively could add to the Pattern example demo?

@williaster williaster added this to the 0.0.198 milestone Jun 15, 2020
@dennisja
Copy link
Contributor Author

@williaster Adding it to the Pattern example sounds and looks better. It is what I have gone with

@dennisja
Copy link
Contributor Author

@williaster I noticed that the build is failing because of some types that are not related to the pull request. I don't know whether it will be a good idea fixing them in this PR for the build to pass. Is can we add an issue to fix them or should I go ahead and fix them in this PR?

@hshoff
Copy link
Member

hshoff commented Jun 18, 2020

@dennisja could you rebase your branch from upstream and push? the fix landed in #751

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the build, thanks again for this addition @dennisja!

@williaster williaster merged commit f3d2b30 into airbnb:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pattern] add support for left-to-right diagonal lines
3 participants