[shape] Add tests for Arc, AreaClosed, & Line #95
Conversation
| @@ -13,7 +13,7 @@ export default function AreaClosed({ | |||
| strokeDasharray, | |||
| strokeWidth = 2, | |||
| stroke = 'black', | |||
| fill = rgba(0,0,0,0.3), | |||
| fill = "rgba(0,0,0,0.3)", | |||
There was a problem hiding this comment.
nice catch. not sure if we've thought about adding .eslint for the library but I think single quotes are preferred for strings
There was a problem hiding this comment.
Oh good point! Sorry about that.
Side question: Is there an beautifier for the Airbnb JS style? Also, would anyone mind if I added an .eslint and checks to the travis build?
There was a problem hiding this comment.
beautifier as in an IDE plugin of sorts? I'm not totally sure about that one but harry might know.
I think adding linting to the root of the vx repo and running it for travis could be a good call for catching things like this (and shouldn't require adding it to every package). the number of errors flagged on the initial pass can be a little rough though and it will flag things like propTypes + defaultProps not being defined for components but could add them to the ignore list to start. Happy to give this a shot as well / recently set it up for the @data-ui repo.
I'd imagine @Harry has probably given this all some thought already, though?
There was a problem hiding this comment.
Oh, I might beat you to it. 😅
There was a problem hiding this comment.
Though I did steal your .eslintrc 😜
Also fixed a bug where
rgba()was treated as a function because it wasn't in quotes and therefore would cause anundefinederror.