Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename main branch to main? #211

Closed
zkat opened this issue Aug 8, 2020 · 7 comments · Fixed by #213
Closed

Rename main branch to main? #211

zkat opened this issue Aug 8, 2020 · 7 comments · Fixed by #213

Comments

@zkat
Copy link
Collaborator

zkat commented Aug 8, 2020

What do y'all think? Plz no trolls

@goto-bus-stop
Copy link
Member

Maybe we can run https://github.com/mheap/github-default-branch for the entire http-rs org?

@yoshuawuyts
Copy link
Member

Yep, let's do it! I believe GitHub will soon release tools to make this transition easy, but if folks want to move ahead before that we can as well!

@Fishrock123
Copy link
Member

Yeah I was thinking about this as well, I don't have any objections.

Though I do wish github had chosen "trunk", oh well.

@goto-bus-stop
Copy link
Member

I can do this tomorrow. We'll also need to update a bunch of references to the branch name, but it looks like that's just in readmes and not in things like action configs, so not super high stakes stuff.

One potentially annoying thing for end users is that Cargo uses the master branch for git dependencies by default regardless of what we configure in Github. So if folks are doing things like surf = { git = "https://github.com/http-rs/surf.git" } that will break.
Then again if you're depending on a branch and not a particular commit you can expect to get breaking changes without warning, and this is just one of them 😇

@zkat
Copy link
Collaborator Author

zkat commented Aug 8, 2020

Cargo should tbh probably be patched so that it uses the remote HEAD, tbh. That seems like a pretty bad Cargo bug.

@goto-bus-stop
Copy link
Member

It looks like that behaviour was recently changed: rust-lang/cargo#8364
So maybe what I said isn't true anymore? I'm not sure if that PR is in a Rust release already.

@goto-bus-stop
Copy link
Member

^ that should be all of them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants