Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inheriting API key from collection and passing as param doesn't work #93

Closed
1 task done
CliveStHelmet opened this issue Jul 13, 2023 · 4 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@CliveStHelmet
Copy link

What happened?

API keys configured on a collection are not sent along with requests associated with that collection if using the As param option. They appear to work as expected if using the As header option. This applies to API keys retrieved from environment variables, and API keys configured directly within the collection. This happens in both the MacOS and Windows versions of HTTPie (both v2023.3.0).

Steps to reproduce?

1. Create a new collection
2. Set Auth to `API key`
3. Set type to `As param`
4. Add a key/value pair containing the name of the parameter and the API key to be passed
5. Create a new request
6. Set Auth to `Inherited`
7. Observe in the Preview that no query parameters are added

Can reproduce in MacOS and Windows.

What did you expect to happen?

I expected the query parameters configured on the collection to be inherited by requests associated with the collection.

Platform

macOS

HTTPie Desktop version

2023.3.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@CliveStHelmet CliveStHelmet added the bug Something isn't working label Jul 13, 2023
@di9eiko0dcikv
Copy link

I have the same problem. I hope this bug will be fixed soon. It's a great tool. Thanks to the people who work hard for this project!

@naxels
Copy link

naxels commented Sep 3, 2023

Unfortunately I discovered the same bug today. I'm using the macOS version: 2023.3.5 (2023.3.5)

@jkbrzt
Copy link
Member

jkbrzt commented Sep 3, 2023

We’re working on a fix 🛠️

@jkbrzt
Copy link
Member

jkbrzt commented Jan 3, 2024

✅ Fixed in v2024.1.1 →

@jkbrzt jkbrzt closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants