Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in behavior for integer #237

Closed
stevenou opened this issue Jun 2, 2023 · 1 comment
Closed

Change in behavior for integer #237

stevenou opened this issue Jun 2, 2023 · 1 comment

Comments

@stevenou
Copy link

stevenou commented Jun 2, 2023

In versions prior to 2.9.0, one could set an integer setting to nil (or not set it at all). Now, due to deserialize method that forces to_i, a nil value deserializes to 0 instead of nil.

Therefore, it breaks any code checking for nil setting. I believe nil should be a legitimate value that should be allowed for an integer setting.

@huacnlee
Copy link
Owner

huacnlee commented Jun 2, 2023

Just released v2.9.2 to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants