Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubeProxyMode and taints params #424

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

smilemusic
Copy link
Contributor

$ make testacc TEST=./huaweicloud/ TESTARGS='-run TestAccCCEClusterV3_basic -mod=readonly'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/ -v -run TestAccCCEClusterV3_basic -mod=readonly -timeout 360m
=== RUN TestAccCCEClusterV3_basic
--- PASS: TestAccCCEClusterV3_basic (361.72s)
PASS
ok github.com/terraform-providers/terraform-provider-huaweicloud/huaweicloud 361.931s

$ make testacc TEST=./huaweicloud/ TESTARGS='-run TestAccCCENodeV3_basic -mod=readonly'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/ -v -run TestAccCCENodeV3_basic -mod=readonly -timeout 360m
=== RUN TestAccCCENodeV3_basic
--- PASS: TestAccCCENodeV3_basic (1356.26s)
PASS
ok github.com/terraform-providers/terraform-provider-huaweicloud/huaweicloud 1356.482s

@@ -130,6 +130,10 @@ func resourceCCEClusterV3() *schema.Resource {
ForceNew: true,
ValidateFunc: validateIP,
},
"kube_proxy_mode": {
Type: schema.TypeString,
Optional: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the parameter can not be updated smoothly, please add the ForceNew behavior.

@@ -64,7 +64,7 @@ versions are available, choose Dashboard > Buy Cluster on the CCE console. Chang

* `subnet_id` - (Required) The ID of the subnet used to create the node. Changing this parameter will create a new cluster resource.

* `highway_subnet_id` - (Optional) The ID of the high speed network used to create bare metal nodes. Changing this parameter will create a new cluster resource.
* `highway_subnet_id` - (Optional) The ID of the high speed network used to create bare metal nodes. Changing this parameter will create a new cluster resource.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make no sense

@@ -31,6 +31,11 @@ resource "huaweicloud_cce_node_v3" "node_1" {
size = 100
volumetype = "SATA"
}
taints {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the taints is too advanced option for a basic usage.

@@ -99,6 +104,16 @@ If the eip_id parameter is configured, you do not need to configure the bandwidt
* `volumetype` - (Required) Disk type.

* `extend_param` - (Optional) Disk expansion parameters.

**taints** **- (Optional)** Represents the data disk to be created. Changing this parameter will create a new resource.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong description for taints?

@smilemusic smilemusic force-pushed the cce-kubeporxymod branch 2 times, most recently from 31cd5a6 to 42767c6 Compare July 31, 2020 02:36
@ghost ghost added size/S and removed size/M labels Jul 31, 2020
@niuzhenguo niuzhenguo merged commit 2bf39b7 into huaweicloud:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants