-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement top_p / nucleus sampling #819
Conversation
Looks great, thanks! Could you describe a bit the testing that you've done? Just want to be sure that it covers running all the modified CLIs as well as the different web UIs. |
Thank you! And thank you for creating candle!
I also tested that even with high And here's
Done |
Great thanks, will merge once the CI has run! |
rustfmt seems to fail, could you have a look please? |
sorry about that! Should be fixed now. I also added the new test file I forgot to commit before |
Thank for apply rustfmt, clippy seems to be having some failures now :) |
Sorry again. Hopefully, it's all fixed now 🙏 |
Thanks, merged! |
This is an implementation of nucleus sampling, introduced in the paper The Curious Case of Neural Text Degeneration.
It's supported by llama-cpp, llama2.c, open ai and others.