Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Langevin Dynamics Sampler #84

Open
natolambert opened this issue Jul 12, 2022 · 6 comments
Open

[Feature] Add Langevin Dynamics Sampler #84

natolambert opened this issue Jul 12, 2022 · 6 comments

Comments

@natolambert
Copy link
Contributor

natolambert commented Jul 12, 2022

The score-based generative models sometimes us a Langevin Dynamics step to de-noise samples; see NCSN. In the diffusion model for generating molecule conformations, GeoDiff, this step function had the best results (even though it is simpler than the score-based schedulers currently in the repo).

It could be worth adding to the repo, likely after the branch #54 is added.

cc @MinkaiXu

@anton-l anton-l self-assigned this Aug 3, 2022
@anton-l anton-l removed their assignment Oct 27, 2022
@anton-l
Copy link
Member

anton-l commented Oct 27, 2022

@natolambert would you like to implement it, if still relevant to GeoDiff?

@natolambert
Copy link
Contributor Author

@anton-l I got GeoDiff working without it (good enough results for colab).
Let me see if this is easy to implement now that I know more.

@natolambert
Copy link
Contributor Author

Okay, found some pointers. This seems like it would be one of the simplest Schedulers.

  • Seems like the NSCN paper was the one to popularize this.
  • The implementation in GeoDiff is here (a little different due to the modality).

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Nov 21, 2022
@natolambert natolambert reopened this Nov 30, 2022
@natolambert natolambert added good first issue Good for newcomers and removed stale Issues that haven't received updates labels Nov 30, 2022
@natolambert
Copy link
Contributor Author

Initial progress on this is done in #1032.

The things that need to be done are:

  • integration tests (there is a sketch in the PR)
  • changing the API to index discrete sigmas rather than the list of sigmas (like SDE VE)
  • make timesteps continuous (not 100% sure on this)
  • showcase examples in a colab / another form to verify functionality.

Maybe @MinkaiXu -- expressed interest.

@MinkaiXu
Copy link

MinkaiXu commented Dec 1, 2022

Yes, glad to contribute @natolambert. Maybe we can find time to chat about this later next week.

@patrickvonplaten patrickvonplaten added Good second issue and removed good first issue Good for newcomers labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants