-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kwargs
from compute
to a config pass during load
#169
Comments
I like this proposal to move all To help gauge the difference, could you share some pseudocode that demonstrates what the new API would look like for a "simple" (few |
Is this actually solved since it is reverted in #299 ? |
I'm also confused as to where this is at? I'm not even sure if this is even where it is being tracked. |
Currently, there is a mix between configs that are used when the metric is instantiated and configs that are later passed to
compute
. This makes life harder in several ways as pointed out in #137 and #138 and also makes thecombine
function from #150 harder to use. The two main points:evaluator
andcombine
).I think we could solve this by moving all kwargs to the
load
. If a user wants to run a metric with different configs they can just load several instances of the metric which is cheap. In addition we could wrap the configs in something like adataclass
that specifies the types of configs and options when only a limited number of options are available (e.g. F1 can only be usebinary
ormultilabel
).What do you think? @lewtun @lhoestq @sashavor
The text was updated successfully, but these errors were encountered: