Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document model repo best practices #53

Open
osanseviero opened this issue Aug 25, 2021 · 2 comments
Open

Document model repo best practices #53

osanseviero opened this issue Aug 25, 2021 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@osanseviero
Copy link
Member

I would like to start documenting good practices of model repos to add to our documentation.

Some come to mind rather quickly

  • One model per repo (avoid having multiple models in the same repo)
  • Add metadata to the model card
  • Add metrics to the metadata of the model card

How do we want to encourage users to have multiple checkpoints in a single repo? There was a related discussion in GPT-J and for other contributions

  • One branch per checkpoint?
  • One commit per checkpoint?

My suggestion

  • When using checkpoints for version control, use a commit per checkpoint
    • For example, Mistral has 600 checkpoints per model. Each checkpoint correspond to a different step. In that sense, I think it makes sense to have a commit/tag per checkpoint
  • When using checkpoints of a model with slightly different characteristics, use a branch per checkpoint
    • For example, GPT-J 6B has a half precision checkpoint and a single precision checkpoint.

I'm just gathering ideas so any are welcome!

cc @patrickvonplaten @julien-c @LysandreJik @lewtun @NielsRogge I hope I did not forget anyone

@osanseviero osanseviero self-assigned this Aug 25, 2021
@StellaAthena
Copy link

In #13022, @xloem raises an important point about git-lfs:

Just a note that for organizing models outside the hugging face cache, it is more convenient to have subfolders or separate repos for different content, because git-lfs can be very slow filtering many gigabytes when switching branches. Not planning on arguing the point, just making sure the use-case is shared.

@LysandreJik LysandreJik transferred this issue from huggingface/huggingface_hub Mar 16, 2022
@osanseviero osanseviero added the documentation Improvements or additions to documentation label Mar 17, 2022
@lewtun
Copy link
Member

lewtun commented Mar 21, 2022

cc @lvwerra who has experience with creating model repos with multiple checkpoints for largish models like CodeParrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants