-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a FlaxModelHubMixin
#1709
Comments
Hi @Wauplin : Can I work on this issue ? |
Hi @sanjeevk-os thanks for proposing to work on this PR! ❤️ Yes, it is free to work on so I can assign it to you. Please let me know if you need any assistance. |
Hey @Wauplin, i would love to contribute here. I have to say i do not have any experience in Flax though and would need some guidance. 😄 |
Hi @lappemic, thanks for proposing your help on this one. However I do think it's best if the mixin gets implemented by someone with at least some knowledge of the Flax ecosystem, at least to know the different corner cases that could exist. I wouldn't want to do it myself either to be honest (I have set the "good first issue" label because it is an issue that requires little knowledge of Would you be interested in other pure-Python pure-huggingface_hub good first issues like #1595 or #1808 maybe? |
Related to this slack thread (private) cc @NielsRogge @osanseviero
We have a generic
ModelHubMixin
that helps integrating any machine learning framework with the Hub as long as one inherits an object from both the framework's main class andModelHubMixin
. Once inherited, one have to implement the_from_pretrained
and_save_pretrained
methods to specify how the files should be serialized on the Hub. From that mixin, we derived aPyTorchModelHubMixin
that is specifically targeted for PyTorch. The serialization/deserialization is already implemented, making it directly plug-able to any Pytorch model. Here is a more thorough description in the documentation.A good addition would be to implement a
FlaxModelHubMixin
class directly inhuggingface_hub
, in the same wayPyTorchModelHubMixin
is already implemented. The purpose is to be able to host/load any Flax models on the Hugging Face Hub.EDIT: tagging it as good first issueGood for newcomers
as it is a self-contained issue that can be implemented on its own. It requires a bit of knowledge about Flax serialization methods. Feel free to ask questions.
The text was updated successfully, but these errors were encountered: