Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: upgrade autoawq to latest version #1684

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

younesbelkada
Copy link
Contributor

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member

Would it be possible to use pip install autoawq and pip install autoawq-kernels to always stay on the latest release?

@younesbelkada
Copy link
Contributor Author

I think this is not possible since the wheels pushed on pypi are specific to some python and cuda version that are diffferent from the one in our docker image

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, hopefully we have a ✔️ in our CI tomorrow.

I think this is not possible since the wheels pushed on pypi are specific to some python and cuda version that are diffferent from the one in our docker image

That's too bad, this means we have to constantly keep watch to update the version in the Dockerfile :-/

@younesbelkada younesbelkada merged commit 8bc3c08 into main Apr 26, 2024
16 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-2 branch April 26, 2024 13:49
@BenjaminBossan
Copy link
Member

BenjaminBossan commented Apr 29, 2024

Hmm, still getting

FAILED tests/test_gpu_examples.py::PeftAwqGPUTests::test_causal_lm_training_awq - NameError: name 'awq_ext' is not defined

When the docker image was built, the new AWQ was installed though:

https://github.com/huggingface/peft/actions/runs/8864028864/job/24338764854#step:6:2396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants