Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease memory usage of merge_and_unload #1944

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Decrease memory usage of merge_and_unload #1944

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f88d1c3
yo
snarayan21 Jul 22, 2024
d33aad9
yo
snarayan21 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/peft/tuners/lora/layer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ def merge(self, safe_merge: bool = False, adapter_names: Optional[list[str]] = N
orig_weights = base_layer.weight.data.clone()
delta_weight = self.get_delta_weight(active_adapter)
if not self.use_dora[active_adapter]:
orig_weights = orig_weights + delta_weight
orig_weights += delta_weight
else:
# handle dora
# since delta_weight already includes scaling, set it to 1 here
Expand All @@ -452,7 +452,7 @@ def merge(self, safe_merge: bool = False, adapter_names: Optional[list[str]] = N
else:
delta_weight = self.get_delta_weight(active_adapter)
if not self.use_dora[active_adapter]:
base_layer.weight.data = base_layer.weight.data + delta_weight
base_layer.weight.data += delta_weight
else:
# handle dora
# since delta_weight already includes scaling, set it to 1 here
Expand Down Expand Up @@ -659,7 +659,7 @@ def merge(self, safe_merge: bool = False, adapter_names: Optional[list[str]] = N
# Note that safe_merge will be slower than the normal merge
# because of the copy operation.
orig_weights = base_layer.weight.data.clone()
orig_weights = orig_weights + self.get_delta_weight(active_adapter)
orig_weights += self.get_delta_weight(active_adapter)

if not torch.isfinite(orig_weights).all():
raise ValueError(
Expand All @@ -668,7 +668,7 @@ def merge(self, safe_merge: bool = False, adapter_names: Optional[list[str]] = N

base_layer.weight.data = orig_weights
else:
base_layer.weight.data = base_layer.weight.data + self.get_delta_weight(active_adapter)
base_layer.weight.data += self.get_delta_weight(active_adapter)
self.merged_adapters.append(active_adapter)

def unmerge(self) -> None:
Expand Down Expand Up @@ -900,7 +900,7 @@ def merge(self, safe_merge: bool = False, adapter_names: Optional[list[str]] = N
delta_weight = self.get_delta_weight(active_adapter)

if not self.use_dora[active_adapter]:
orig_weights = orig_weights + delta_weight
orig_weights += delta_weight
else:
# handle dora
# since delta_weight already includes scaling, set it to 1 here
Expand All @@ -924,7 +924,7 @@ def merge(self, safe_merge: bool = False, adapter_names: Optional[list[str]] = N
else:
delta_weight = self.get_delta_weight(active_adapter)
if not self.use_dora[active_adapter]:
base_layer.weight.data = base_layer.weight.data + delta_weight
base_layer.weight.data += delta_weight
else:
# handle dora
# since delta_weight already includes scaling, set it to 1 here
Expand Down
Loading