CI Only run a single Windows workflow #1947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
Jul 24, 2024
For some **** reason, Windows CI suddenly started throwing permission errors on test_merge_layers. These errors occur when using the TempDirectory() context manager, which raises a PermissionError on Windows when it tries to clean up after itself. Therefore, this context manager is now avoided in favor of manual clean up. More context: I investigated this issue first in huggingface#1947. My suspicion that this could be caused by a new pytest version was not confirmed. Maybe the reason is that GH rolled out a new Windows worker, not sure. Also note that this is not the first time that this workaround is required, e.g. also here: https://github.com/huggingface/peft/blob/e6cd24c907565040ee1766a5735afe3d13a71164/tests/test_custom_models.py#L1465
BenjaminBossan
added a commit
that referenced
this pull request
Jul 25, 2024
For some reason, Windows CI suddenly started throwing permission errors on test_merge_layers. These errors occur when using the TempDirectory() context manager, which raises a PermissionError on Windows when it tries to clean up after itself. Therefore, this context manager is now avoided in favor of manual clean up. More context: I investigated this issue first in #1947. My suspicion that this could be caused by a new pytest version was not confirmed. Maybe the reason is that GH rolled out a new Windows worker, not sure. Also note that this is not the first time that this workaround is required, e.g. also here: https://github.com/huggingface/peft/blob/e6cd24c907565040ee1766a5735afe3d13a71164/tests/test_custom_models.py#L1465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE