Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pip install directly from GitHub #1671

Closed
jamesbraza opened this issue Nov 2, 2024 · 3 comments
Closed

Support pip install directly from GitHub #1671

jamesbraza opened this issue Nov 2, 2024 · 3 comments

Comments

@jamesbraza
Copy link

With Python 3.12.7 and pip==24.3.1, the below does not work:

> pip install git+https://github.com/huggingface/tokenizers.git#subdirectory=tokenizers
Collecting git+https://github.com/huggingface/tokenizers.git#subdirectory=tokenizers
  Cloning https://github.com/huggingface/tokenizers.git to /private/var/folders/5c/20jqnfqx4sv1_6_bdkf765cr0000gn/T/pip-req-build-b1vkwjey
  Running command git clone --filter=blob:none --quiet https://github.com/huggingface/tokenizers.git /private/var/folders/5c/20jqnfqx4sv1_6_bdkf765cr0000gn/T/pip-req-build-b1vkwjey
  Resolved https://github.com/huggingface/tokenizers.git to commit 6c15458868bc79dce134dc821c1c0359f3180f2f
ERROR: git+https://github.com/huggingface/tokenizers.git#subdirectory=tokenizers does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

It would be cool if tokenizers supported pip installing from GitHub to get the latest source code, e.g. for Python 3.13 support.

@ArthurZucker
Copy link
Collaborator

Yeah sounds interesting, will look into this!
Will do the release today!

@gau-nernst
Copy link

@jamesbraza I think you point to the wrong subdirectory. This should work

pip install git+https://github.com/huggingface/tokenizers.git#subdirectory=bindings/python

@jamesbraza
Copy link
Author

Oh wow you are right, I did. Closing this as resolved, thanks @gau-nernst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants