Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move weight initialization for DeformableDetr #29818

Closed
EduardoPach opened this issue Mar 22, 2024 · 8 comments · Fixed by #33339
Closed

Move weight initialization for DeformableDetr #29818

EduardoPach opened this issue Mar 22, 2024 · 8 comments · Fixed by #33339
Labels
Good First Issue Should Fix This has been identified as a bug and should be fixed. Vision

Comments

@EduardoPach
Copy link
Contributor

EduardoPach commented Mar 22, 2024

System Info

Not relevant

Reproduction

See Deformable Detr Modeling.

Expected behavior

All weight initializations should be done in _init_weights of the xxxPretrainedModel class

@EduardoPach
Copy link
Contributor Author

c.c. @amyeroberts

@amyeroberts
Copy link
Collaborator

A note for anyone coming to this: this is for all DETR related models

cc @NielsRogge

@amyeroberts amyeroberts added Should Fix This has been identified as a bug and should be fixed. Vision labels Mar 23, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@EduardoPach
Copy link
Contributor Author

Will work on this this week

@huggingface huggingface deleted a comment from github-actions bot May 17, 2024
@huggingface huggingface deleted a comment from github-actions bot Jun 11, 2024
@huggingface huggingface deleted a comment from github-actions bot Jul 6, 2024
@huggingface huggingface deleted a comment from github-actions bot Jul 31, 2024
@huggingface huggingface deleted a comment from github-actions bot Aug 27, 2024
@amyeroberts
Copy link
Collaborator

Any update @EduardoPach?

@EduardoPach
Copy link
Contributor Author

Any update @EduardoPach?

Busy with other things lately and prioritizing my free time to more impactful contributions. I believe this issue could be tagged with good-first-issue though

@g-prz
Copy link
Contributor

g-prz commented Aug 30, 2024

Hello @amyerobert ! I am interested in working on that issue (as my first issue).

I dove a little bit into the issue, if I reformulate it:

  • mainly moving the _reset_parameters() function into the _init_weights()
  • there is the same issue to tackle in GroundingDino model

@amyeroberts
Copy link
Collaborator

@g-prz Yep - that's right! When you're ready feel free to open a PR and ping me for review 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Should Fix This has been identified as a bug and should be fixed. Vision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants