Correct attention mask dtype for Flax GPT2 #25636
Merged
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liutianlin0121
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
liutianlin0121
force-pushed
the
attention_mask
branch
from
2f1e4cb to
1a9d3dd
Compare
|
@ArthurZucker Sure! I added a test :-) |
liutianlin0121
force-pushed
the
attention_mask
branch
from
1a9d3dd to
aa34af0
Compare
@sanchit-gandhi Good point! Done. Let me know if you have further suggestions. :-) |
liutianlin0121
force-pushed
the
attention_mask
branch
from
aa34af0 to
7f966d7
Compare
ArthurZucker
approved these changes
Aug 24, 2023
|
cc @sanchit-gandhi feel free to merge if it's alright with you! |
liutianlin0121
force-pushed
the
attention_mask
branch
from
42b2414 to
9d97878
Compare
|
@sanchit-gandhi Hey thanks! I change to assertTrue. |
sanchit-gandhi
approved these changes
Aug 25, 2023
|
No problem! Feel free to merge it (it seems that I can't). |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* Correct attention mask dtype * reformat code * add a test for boolean mask * convert test to fast test * delete unwanted print * use assertTrue for testing
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* Correct attention mask dtype * reformat code * add a test for boolean mask * convert test to fast test * delete unwanted print * use assertTrue for testing
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* Correct attention mask dtype * reformat code * add a test for boolean mask * convert test to fast test * delete unwanted print * use assertTrue for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #25634
Before submitting
Pull Request section?
to it if that's the case. Link: Problem caused by boolean attention mask in
pretrained_model.generateof Flax GPT2 #25634documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sanchit-gandhi
@ArthurZucker