Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASR Pipe Test] Fix CTC timestamps error message #25727

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

sanchit-gandhi
Copy link
Contributor

What does this PR do?

The test test_chunking_and_timestamps failed on the nightly run when checking that the argument return_timestamps=True gave the correct error message for CTC models. This is because the string pattern (char) in the error message was closing the regex expression. Removing it allows the test to pass as expected.

@sanchit-gandhi sanchit-gandhi requested a review from ydshieh August 24, 2023 12:54
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. Thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 24, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sanchit-gandhi sanchit-gandhi merged commit 0218876 into huggingface:main Aug 24, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants