Add flax installation in daily doctest workflow #25860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
As Flax and Jax break our environments frequently because of (large) breaking changes in their releases and it's a pain to managed, could we pin the install to the highest version currently allowed in setup.py? |
|
Hi @amyeroberts , with python3 -m pip install -e .[flax]it should already respect the versions we specify in |
|
@amyeroberts jax, jaxlib, and flax are pinned in the setup, so it should be okay :D (e.g. here) |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#25763 enables the doctesting against a few more files, including some flax related files. As the docker image doesn't have flax/jax installed, the pytest failed to collect the test to run, see this doctest run:
src/transformers/generation/flax_utils.py - ModuleNotFoundError: No module named 'flax'Let's install jax/flax in the doctest workflow, and see what this gives us.
Note we don't want to install jax/flax in the docker image, as the same image is used for daily (non-doctest) CI, and we don't want to have them to (potentially) interfere the CI.