nn.Identity is not required to be compatible with PyTorch < 1.1.0 as the minimum PyTorch version we currently support is 1.10.0 #25974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure I understand. We already say goodbye to pytorch 1.9 in #24080. Could you elaborate with a bit more detail? |
minimum PyTorch version we currently support is 1.10.0
statelesshz
force-pushed
the
remove_dead_code
branch
from
3530cc2 to
6f1406f
Compare
statelesshz
changed the title
Apologies for the confusion. I provided incorrect information about the minimum supported version of transformers. :( |
ydshieh
approved these changes
Sep 5, 2023
amyeroberts
approved these changes
Sep 5, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…the minimum PyTorch version we currently support is 1.10.0 (huggingface#25974) nn.Identity is not required to be compatible with PyTorch < 1.1.0 as the minimum PyTorch version we currently support is 1.10.0
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
…the minimum PyTorch version we currently support is 1.10.0 (huggingface#25974) nn.Identity is not required to be compatible with PyTorch < 1.1.0 as the minimum PyTorch version we currently support is 1.10.0
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
…the minimum PyTorch version we currently support is 1.10.0 (huggingface#25974) nn.Identity is not required to be compatible with PyTorch < 1.1.0 as the minimum PyTorch version we currently support is 1.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the title says.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerz and @pacman100