Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcon: fix revision propagation #26006

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

LysandreJik
Copy link
Member

Revision should be kept in the kwargs as these are being propagated throughout the method afterwards.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing!

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! I totally overlooked this as well - I should have scrolled down a few lines below the diff when I was reviewing.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this when reviewing! Thanks 🤗

@LysandreJik LysandreJik merged commit f6301b9 into main Sep 6, 2023
3 checks passed
@LysandreJik LysandreJik deleted the fix-falcon-revision-propagation branch September 6, 2023 11:21
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

LysandreJik added a commit that referenced this pull request Sep 15, 2023
* Fix revision propagation

* Cleaner
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* Fix revision propagation

* Cleaner
LysandreJik added a commit that referenced this pull request Sep 28, 2023
LysandreJik added a commit that referenced this pull request Oct 2, 2023
* Revert "Falcon: fix revision propagation (#26006)"

This reverts commit 118c676.

* Revert "Put Falcon back (#25960)"

This reverts commit 22a69f1.
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* Fix revision propagation

* Cleaner
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* Revert "Falcon: fix revision propagation (huggingface#26006)"

This reverts commit 118c676.

* Revert "Put Falcon back (huggingface#25960)"

This reverts commit 22a69f1.
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* Fix revision propagation

* Cleaner
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* Revert "Falcon: fix revision propagation (huggingface#26006)"

This reverts commit 118c676.

* Revert "Put Falcon back (huggingface#25960)"

This reverts commit 22a69f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants