-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Falcon: fix revision propagation #26006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for fixing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean! I totally overlooked this as well - I should have scrolled down a few lines below the diff when I was reviewing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this when reviewing! Thanks 🤗
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
* Fix revision propagation * Cleaner
* Fix revision propagation * Cleaner
This reverts commit 118c676.
* Fix revision propagation * Cleaner
* Revert "Falcon: fix revision propagation (huggingface#26006)" This reverts commit 118c676. * Revert "Put Falcon back (huggingface#25960)" This reverts commit 22a69f1.
* Fix revision propagation * Cleaner
* Revert "Falcon: fix revision propagation (huggingface#26006)" This reverts commit 118c676. * Revert "Put Falcon back (huggingface#25960)" This reverts commit 22a69f1.
Revision should be kept in the kwargs as these are being propagated throughout the method afterwards.