Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vilt config docstring parameter to match value in init #26017

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix vilt config docstring parameter to match value in init #26017

merged 2 commits into from
Sep 7, 2023

Conversation

raghavanone
Copy link
Contributor

What does this PR do?

Fixes #25639

This PR fixes the Vilt models config's init parameters to match the ones in the documentation.

amyeroberts
amyeroberts reviewed Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR! The fix should go the other way: the documentation is updated to reflect the default values

@raghavanone
Copy link
Contributor Author

Thanks for opening this PR! The fix should go the other way: the documentation is updated to reflect the default values

Oh Yes, Got misled by the discussion here . But checked here , the init is right, only the documentation needs to be changed .

@raghavanone
Copy link
Contributor Author

@amyeroberts Done.

@amyeroberts amyeroberts changed the title Fix vilt config init parameter to match the ones in documentation Fix vilt config docstring parameter to match value in init Sep 7, 2023
amyeroberts
amyeroberts approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@amyeroberts amyeroberts merged commit 00efd64 into huggingface:main Sep 7, 2023
3 checks passed
@raghavanone raghavanone deleted the fix_issue_25639 branch September 7, 2023 22:31
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
@raghavanone @parambharat
Fix vilt config docstring parameter to match value in init (huggingfa…
80eddf6 
…ce#26017)

* Fix vilt config init parameter to match the ones in documentation

* Fix the documentation
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
@raghavanone @blbadger
Fix vilt config docstring parameter to match value in init (huggingfa…
307b793 
…ce#26017)

* Fix vilt config init parameter to match the ones in documentation

* Fix the documentation
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
@raghavanone @EduardoPach
Fix vilt config docstring parameter to match value in init (huggingfa…
00ba39c 
…ce#26017)

* Fix vilt config init parameter to match the ones in documentation

* Fix the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@raghavanone @HuggingFaceDocBuilderDev @amyeroberts