fix: no need to dtype A in jamba #32924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
pushed a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Gal Cohen <galc@ai21.com>
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Aug 30, 2024
Co-authored-by: Gal Cohen <galc@ai21.com>
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Aug 30, 2024
Co-authored-by: Gal Cohen <galc@ai21.com>
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
Co-authored-by: Gal Cohen <galc@ai21.com>
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Gal Cohen <galc@ai21.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Can't use Jamba in FSDP due to A init as FP32 no matter the weights and dtype passed. this behave isn't relevant cause the weights are BF16 and in fwd pass we anyway dtyping when needed as in mamba_2_modeling
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.