Fix position embeddings singular/plural #33678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @amyeroberts for review! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@amyeroberts sorry for the ping, just keeping this one higher in the notifications - hub tests were just flaky :) |
|
Found out about an issue in |
BenjaminBossan
pushed a commit
to BenjaminBossan/transformers
that referenced
this pull request
Sep 30, 2024
* fix position embeddings * [run-slow] blip, blip_2, instructblip, instructblipvideo * fix init * [run-slow] blip, blip_2, instructblip, instructblipvideo * fix copies * [run-slow] blip, blip_2, instructblip, instructblipvideo * [run-slow] blip, blip_2, instructblip, instructblipvideo * handle exception where list + tensors are cat'd * [run-slow] blip, blip_2, instructblip, instructblipvideo * add missing default * [run-slow] blip, blip_2, instructblip, instructblipvideo
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 2, 2024
* fix position embeddings * [run-slow] blip, blip_2, instructblip, instructblipvideo * fix init * [run-slow] blip, blip_2, instructblip, instructblipvideo * fix copies * [run-slow] blip, blip_2, instructblip, instructblipvideo * [run-slow] blip, blip_2, instructblip, instructblipvideo * handle exception where list + tensors are cat'd * [run-slow] blip, blip_2, instructblip, instructblipvideo * add missing default * [run-slow] blip, blip_2, instructblip, instructblipvideo
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* fix position embeddings * [run-slow] blip, blip_2, instructblip, instructblipvideo * fix init * [run-slow] blip, blip_2, instructblip, instructblipvideo * fix copies * [run-slow] blip, blip_2, instructblip, instructblipvideo * [run-slow] blip, blip_2, instructblip, instructblipvideo * handle exception where list + tensors are cat'd * [run-slow] blip, blip_2, instructblip, instructblipvideo * add missing default * [run-slow] blip, blip_2, instructblip, instructblipvideo
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
* fix position embeddings * [run-slow] blip, blip_2, instructblip, instructblipvideo * fix init * [run-slow] blip, blip_2, instructblip, instructblipvideo * fix copies * [run-slow] blip, blip_2, instructblip, instructblipvideo * [run-slow] blip, blip_2, instructblip, instructblipvideo * handle exception where list + tensors are cat'd * [run-slow] blip, blip_2, instructblip, instructblipvideo * add missing default * [run-slow] blip, blip_2, instructblip, instructblipvideo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It seems a few Blip-derived models have both
self.position_embeddingandself.position_embeddings, plural, defined in the same module and causing some errors. This aims at fixing those. Noticed it in #31368 .Causes many things to break because self.position_embedding isn't defined since it's self.position_embeddings (with an s) instead.