Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos_token config in PPOTrainer #2387

Open
kechunFIVE opened this issue Nov 23, 2024 · 1 comment · May be fixed by #2420
Open

eos_token config in PPOTrainer #2387

kechunFIVE opened this issue Nov 23, 2024 · 1 comment · May be fixed by #2420
Labels
✨ enhancement New feature or request 👶 good first issue Good for newcomers 🙋 help from community wanted Open invitation for community members to contribute 🏋 PPO Related to PPO

Comments

@kechunFIVE
Copy link

Feature request

It appears that the generation config in PPOTrainer does not set an eos_token, resulting in each generation process continuing until it reaches the maximum length before stopping, which is quite time-consuming.

Motivation

If the eos_token is set, it will significantly reduce the time spent during the generation phase.

Your contribution

i'm sorry
@qgallouedec
Copy link
Member

Thanks for reporting it. Would you like to open a PR to fix it?

@qgallouedec qgallouedec added ✨ enhancement New feature or request 👶 good first issue Good for newcomers 🏋 PPO Related to PPO labels Nov 26, 2024
@dame-cell dame-cell linked a pull request Nov 30, 2024 that will close this issue
Open
5 tasks
@qgallouedec qgallouedec added the 🙋 help from community wanted Open invitation for community members to contribute label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement New feature or request 👶 good first issue Good for newcomers 🙋 help from community wanted Open invitation for community members to contribute 🏋 PPO Related to PPO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added eos token for ppotrainer dame-cell/trl
2 participants
@qgallouedec @kechunFIVE