Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Feat: support extended alert syntax compatible with Obsidian Callouts #519

Merged
merged 5 commits into from
Oct 10, 2024
Merged

🎉 Feat: support extended alert syntax compatible with Obsidian Callouts #519

merged 5 commits into from
Oct 10, 2024

Conversation

Lruihao
Copy link
Member

@Lruihao Lruihao commented Oct 8, 2024 •
edited
Loading

Change hugo version to ^0.134.1.

Preview Demo

  • Refactor admonition shortcode: add todo type and aliases type
  • Support extended alert syntax compatible with Obsidian Callouts
  • Customize Alerts support

Resolves #518
Resolves #406

If hugo issue gohugoio/hugo#12913 is resolved, remove the dirty hacks in the theme.

FixIt/assets/css/_shortcodes/_admonition.scss

Lines 28 to 31 in 12cc5f7

// BUG of Hugo https://github.com/gohugoio/hugo/issues/12913
&:has(> p:only-child:empty) {
display: none;
}

FixIt/layouts/_default/_markup/render-blockquote-alert.html

Lines 5 to 8 in 12cc5f7

{{- /* === Dirty hack === */ -}}
{{- /* BUG of Hugo https://github.com/gohugoio/hugo/issues/12913 */ -}}
{{- $title := replaceRE "</([a-zA-Z]+)$" "</$1>" .AlertTitle -}}
{{- /* === Dirty hack === */ -}}

@Lruihao
🎉 Feat: support alert foldable title for blockquote compatible with O…
bd40c85 
…bsidian Callouts

refactor admonition shortcode: add todo type and aliases type
change min hugo version: 0.134.0
@Lruihao Lruihao added the enhancement New feature or request label Oct 8, 2024
@Lruihao Lruihao added this to the v0.3.x milestone Oct 8, 2024
@Lruihao Lruihao self-assigned this Oct 8, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fixit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 2:06am

@Lruihao Lruihao linked an issue Oct 8, 2024 that may be closed by this pull request
[FEATURE] Support blockquote extended syntax compatible with Obsidian #518
Closed
@Lruihao Lruihao force-pushed the obsidian-callouts branch from 7d8f137 to 091dcf7 Compare October 8, 2024 07:26
@Lruihao Lruihao marked this pull request as draft October 8, 2024 07:27
@Lruihao Lruihao force-pushed the obsidian-callouts branch from 091dcf7 to cf71f1e Compare October 8, 2024 08:08
@Lruihao Lruihao force-pushed the obsidian-callouts branch from c768e5d to 62a35d4 Compare October 9, 2024 08:38
@Lruihao Lruihao marked this pull request as ready for review October 9, 2024 08:41
@Lruihao Lruihao requested a review from a team October 10, 2024 02:55
@Lruihao Lruihao merged commit f738e4a into dev Oct 10, 2024
2 checks passed
@Lruihao Lruihao deleted the obsidian-callouts branch October 10, 2024 02:57
Lruihao added a commit that referenced this pull request Dec 13, 2024
@Lruihao
🐛 Fix: blockquote render hook text parsing (#519)
8fa970d
Lruihao added a commit that referenced this pull request Dec 13, 2024
@Lruihao
🐛 Fix: blockquote render hook text parsing (#519)
d2c4d7c
Lruihao added a commit that referenced this pull request Dec 25, 2024
@Lruihao
Merge pull request #564 from hugo-fixit/fix-alert
54675a6 
🐛 Fix: blockquote render hook text parsing (#519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Lruihao Lruihao

Labels
enhancement New feature or request
Projects
Roadmap of FixIt
Status: Done
Milestone
v0.3.x
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support blockquote extended syntax compatible with Obsidian
1 participant
@Lruihao