Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove porcelain dependency? #1

Closed
hugomaiavieira opened this issue Aug 19, 2018 · 3 comments
Closed

Remove porcelain dependency? #1

hugomaiavieira opened this issue Aug 19, 2018 · 3 comments

Comments

@hugomaiavieira
Copy link
Owner

The porcelain package is not been maintained very well, has knowing design flaws that can lead into zombie processes, and is showing some deprecation warnings on compilation.

Removing it will make this package dependency free (besides wkhtmltopdf of course). Also it will solve the hot code upgrading using distillery issue.

There is a specific reason to use porcelain? Couldn't we use the built in System.cmd/3 function?

TODO: read more about Port module, the zombie processes, and the porcelain's basic driver to try to answer the questions above and create an issue on the original repo.

@gutschilla
Copy link

Excuses

@hugomaiavieira You're right about Porcelain. Back in 2015, when this module came to life, Porcelain was the easiest way to get something started without needing to dig into the ports (The documentation was, well, like this: https://hexdocs.pm/elixir/1.0.5/Port.html#summary). Initially, I didn't want to use temporary files – but then I got it trivially easy working with so I kept it that way.

The bright future

I guess, Ports will do. Just need time to do it ;-)

@hugomaiavieira
Copy link
Owner Author

Thanks for the info @gutschilla! :)

@hugomaiavieira
Copy link
Owner Author

gutschilla#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants