Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search doesn't work sometimes #244

Closed
XyLyXyRR opened this issue Mar 31, 2023 · 2 comments · Fixed by #246
Closed

search doesn't work sometimes #244

XyLyXyRR opened this issue Mar 31, 2023 · 2 comments · Fixed by #246
Labels
bug Something isn't working

Comments

@XyLyXyRR
Copy link

search doesn't work sometimes

Information

  • Chromium Version 111.0.5563.146 (Official Build) Arch Linux (64-bit)
  • Rust Search Extension 1.10.0

logs

base.js:505 Uncaught (in promise) TypeError: result.item.path.toLowerCase is not a function
    at SingleCrateDocSearch.sortResults (base.js:505:41)
    at SingleCrateDocSearch.execQuery (base.js:397:21)
    at SingleCrateDocSearch.search (base.js:71:21)
    at CrateDocSearch.searchAll (crate-doc.js:80:38)
    at async QueryEvent.onSearch (main.js:204:20)
    at async QueryEvent.performSearch (query-event.js:34:22)
    at async Omnibox.performSearch (omnibox.js:200:32)
    at async omnibox.js:81:27
sortResults @ base.js:505
execQuery @ base.js:397
search @ base.js:71
searchAll @ crate-doc.js:80
await in searchAll (async)
(anonymous) @ extensions::omnibox:121
@Folyd Folyd added the bug Something isn't working label Mar 31, 2023
@Folyd
Copy link
Member

Folyd commented Apr 1, 2023

Hi, @notriddle. My extension is broken again due to the changes in the search index. It seems like the item.path has been changed from string to array. Do you know which PR brought such a change? I hope I can figure out how to fix it based on that PR. Thanks. ❤️

image

@Folyd
Copy link
Member

Folyd commented Apr 2, 2023

I found the PR with the breaking change: rust-lang/rust#107629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants