Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about VotingRules for grandpa #365

Closed
dmitrylavrenov opened this issue Jun 1, 2022 · 2 comments
Closed

Think about VotingRules for grandpa #365

dmitrylavrenov opened this issue Jun 1, 2022 · 2 comments
Assignees
Labels
substrate Related to substrate

Comments

@dmitrylavrenov
Copy link
Contributor

At the current moment we use default voting rules for grandpa. But there is a way to define a custom rules options like doing finalisation in every 50 blocks, etc.

Here is an example from polkadot node.

@dmitrylavrenov dmitrylavrenov added the substrate Related to substrate label Jun 1, 2022
@MOZGIII MOZGIII self-assigned this Oct 11, 2022
@MOZGIII
Copy link
Contributor

MOZGIII commented Nov 4, 2024

Closing this, as we have had a discussion about this during the incident. The verdict, in short, is voting rules are fine as is - with 2 blocks delay after best block.

@MOZGIII MOZGIII closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substrate Related to substrate
Development

No branches or pull requests

2 participants