Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into setting the max proof size weight on defaults and tests #511

Closed
dmitrylavrenov opened this issue Nov 23, 2022 · 1 comment
Closed

Comments

@dmitrylavrenov
Copy link
Contributor

As a follow up of #510

Related to humanode-network/substrate@61b9a4d

@MOZGIII
Copy link
Contributor

MOZGIII commented Feb 4, 2023

From paritytech/substrate#12383:

The default max proof size is set at u64::MAX, because not all substrate-based chains require submitting PoV blocks to the relay -- standalone sovereign chains can safely ignore this weight component.

For parachains however, the proper parameter to set for the max proof size comes from the relay chain, and is stored a field called max_pov_size in this struct: paritytech/cumulus@032540d/pallets/parachain-system/src/lib.rs#L526.

We are a self-sovereign chain, and we don't send PoV blocks to the relay due to the absence of the said relay.

Thus, we can use u64::MAX everywhere.

We can consider this issue solved for now, and revisit it when/if we start dealing with PoV.

@MOZGIII MOZGIII closed this as completed Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants