Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try more selectors by default to inject the banner #32

Open
humitos opened this issue Apr 10, 2021 · 0 comments
Open

Try more selectors by default to inject the banner #32

humitos opened this issue Apr 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@humitos
Copy link
Owner

humitos commented Apr 10, 2021

Instead of just using var body = $(config.banner.body_selector); we could try multiple selectors:

    var selectors = ['[role=main]', 'main', 'div.body', 'div.document'];

We should make this backward compatible, allowing just one item for this config.

See this comment https://github.com/readthedocs/readthedocs.org/pull/8079/files#r611035817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant